Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

do argmax on logits in torch for BertLMHead #377

Merged
merged 1 commit into from
May 28, 2020
Merged

do argmax on logits in torch for BertLMHead #377

merged 1 commit into from
May 28, 2020

Conversation

tstadel
Copy link
Member

@tstadel tstadel commented May 28, 2020

resolves #375 by increasing evaluation speed by approximately 5 times when using GPU

tholor
tholor approved these changes May 28, 2020
View reviewed changes
Copy link
Member

@tholor tholor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Thanks for fixing this @tstadel. Very helpful for large workloads like training from scratch!

@tholor tholor added enhancement New feature or request part: model task: LM fine Language model fine-tuning labels May 28, 2020
@tholor tholor merged commit edf120e into deepset-ai:master May 28, 2020
@tstadel tstadel deleted the bert_mlm_eval_performance branch May 28, 2020 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tholor tholor tholor approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request part: model task: LM fine Language model fine-tuning
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

slow BERT MLM evaluation
2 participants
@tstadel @tholor