New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document magic data loading in TextClassificationProcessor
PR
#383
Conversation
The CI problem seems to come from this issue: #382 (comment) It is fixed here: 4109389 If you merge this PR: #382 I could just rebase master and this CI error is also fixed. |
Rebased Master |
CI server seems to be broken: Should I do a fake commit to restart...? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the docstring improvements. They make data loading more transparent for the user.
General comment: could you also add the docstring to the other processors, not just TCP? I can also gladly do that when this PR is merged.
This CI error seems really strange. I made a small comment for a proposed change in the TCP docstring - please try another commit with the proposed changes. Hopefully the CI runs through.
I did that. Hope I did not miss anything. |
I think I am done with this. Can you please review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking very well.
Thanks for also adjusting to the proposed changes.
This is the PR for #378
TODO