-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to specify text col name in TextClassificationProcessor
and RegressionProcessor
#387
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it. Having tests also helps a lot. Thanks for this great addition.
I added a small comment in the column renaming.
Lets wait for our CI issue to be fixed, than we can merge it safely.
Could you do a dummy commit to restart the CI, please? (I do not have access to the pipeline, today is public holiday in Germany...) |
rebased master |
Fixed |
The CI system was gracious to me and all tests are green now. :-) Can you please do a review? Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small check is needed, than we can merge.
I would also merge irrespective of our CI status, since the pipeline ran through already. The problems seem to come from Azure side. Apparently there are not enough resources for open source code at all times and we currently investigate alternatives like github actions.
Made the change discussed above. I am passing The advantage is memory usage and early crashing. If one of the cols does not exist (because the user mistyped it) I think this should adress the concerns from @Timoeller in the review. |
rebased master (mainly to trigger CI again) |
YAY! CI is green. :-) |
CSV data reading is handled much more user friendly now. Thanks @PhilipMay for your effort. |
PR for #379
TODO