Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert pydantic objects to regular classes #410

Merged
merged 3 commits into from Jun 17, 2020
Merged

Convert pydantic objects to regular classes #410

merged 3 commits into from Jun 17, 2020

Conversation

brandenchan
Copy link
Contributor

To increase inference speed, the pydantic objects have been converted to regular classes with type hints but no type check

Timoeller
Timoeller approved these changes Jun 17, 2020
View reviewed changes
Copy link
Contributor

@Timoeller Timoeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pydantic made QA inferencing slower by about 15%.
So we removed it.

Tested the code, also on accuracy benchmarks. Looking good.

@Timoeller Timoeller merged commit efd8132 into master Jun 17, 2020
@tholor tholor mentioned this pull request Sep 9, 2021
Merged
23 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Timoeller Timoeller Timoeller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@brandenchan @Timoeller