Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in benchmark tests with if statement #430

Merged
merged 2 commits into from
Jul 8, 2020

Conversation

PhilipMay
Copy link
Contributor

I think I found a strange bug. Can you please review this?
I am not 100% sure if it is fixed now.

@tanaysoni
Copy link
Contributor

Hi @PhilipMay, thank you for raising this fix! I did a minor change on your branch to make it more readable. If you think it's okay, then this PR is good-to-go.

@PhilipMay
Copy link
Contributor Author

LGTM

@tanaysoni tanaysoni merged commit 16628c0 into deepset-ai:master Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants