Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade transformers version #448

Merged
merged 5 commits into from Jul 9, 2020
Merged

Upgrade transformers version #448

merged 5 commits into from Jul 9, 2020

Conversation

tholor
Copy link
Member

@tholor tholor commented Jul 8, 2020

Upgrading to latest transformers (3.0.2). This will allow us to move to the faster rust tokenizers and use Electra in Haystack.

@tholor
Copy link
Member Author

tholor commented Jul 9, 2020

QA accuracy benchmark was running successfully

@tholor tholor requested a review from Timoeller July 9, 2020 07:28
Timoeller
Timoeller suggested changes Jul 9, 2020
View reviewed changes
Copy link
Contributor

@Timoeller Timoeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested doc classification with German Bert. Preprocessing is fast as hell : )
Performance is even better than on our blog post.

I made comments where we need changes

farm/modeling/tokenization.py Show resolved Hide resolved
test/test_conversion.py Outdated Show resolved Hide resolved
@tholor tholor merged commit 6cf268a into master Jul 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Timoeller Timoeller Timoeller requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tholor @Timoeller