Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store test eval result in variable #506

Merged
merged 1 commit into from
Aug 31, 2020

Conversation

PhilipMay
Copy link
Contributor

@PhilipMay PhilipMay commented Aug 30, 2020

  • add self.test_result and init it with None
  • set self.test_result with eval result
  • add docstring
  • write (extend) test

This does not introduce any breaking change.

Also see #496

- add self.test_result and init it with None
- set self.test_result with eval result
- add docstring
- write (extend) test
Copy link
Member

@tholor tholor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple and effective. I like it!
Thanks for adding this @PhilipMay !

@tholor tholor merged commit eaf5b9c into deepset-ai:master Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants