This repository has been archived by the owner on Nov 28, 2023. It is now read-only.
fix: draw function vs init parameters
#115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZanSara
commented
Sep 26, 2023
| @@ -95,7 +95,7 @@ def _prepare_for_drawing(graph: networkx.MultiDiGraph, style_map: Dict[str, str] | |||
| graph.add_node("input") | |||
| for node, in_sockets in _find_pipeline_inputs(graph).items(): | |||
| for in_socket in in_sockets: | |||
| if in_socket.sender is None: | |||
| if in_socket.sender is None and not in_socket.is_optional: | |||
There was a problem hiding this comment.
Prevents optional inputs from being drawn
| _draw(graph=deepcopy(self.graph), path=path, engine=engine) | ||
| _draw(graph=networkx.MultiDiGraph(self.graph), path=path, engine=engine) |
There was a problem hiding this comment.
Deepcopy replaced with the initialization of a new graph (shallow copy). Less safe in theory, however the draw functions only affect the graph edges, so no harm should be done to the components.
silvanocerza
approved these changes
Sep 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
We recently discovered that many Haystack components break the draw function due to the complexity of their init parameters.
What
mermaid-imgtomermaid-imageto be consistent withmermaid-textTests
Results
Example RAG: