Remove Literal type hint (#156)

deepset-ai · Jun 17, 2020 · 8bcc4b2 · 8bcc4b2
1 parent af5fc79
commit 8bcc4b2
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/haystack/api/controller/search.py b/haystack/api/controller/search.py
@@ -45,7 +45,7 @@
     retriever = EmbeddingRetriever(
         document_store=document_store,
         embedding_model=EMBEDDING_MODEL_PATH,
-        model_format=EMBEDDING_MODEL_FORMAT,  # type: ignore
+        model_format=EMBEDDING_MODEL_FORMAT,
         gpu=USE_GPU
     )  # type: BaseRetriever
 else:

diff --git a/haystack/retriever/elasticsearch.py b/haystack/retriever/elasticsearch.py
@@ -2,7 +2,6 @@
 from typing import List, Union
 
 from farm.infer import Inferencer
-from typing_extensions import Literal
 
 from haystack.database.base import Document
 from haystack.database.elasticsearch import ElasticsearchDocumentStore
@@ -108,8 +107,8 @@ def __init__(
         document_store: ElasticsearchDocumentStore,
         embedding_model: str,
         gpu: bool = True,
-        model_format: Literal["farm", "transformers", "sentence_transformers"] = "farm",
-        pooling_strategy: Literal["cls_token", "reduce_mean", "reduce_max", "per_token", "s3e"] = "reduce_mean",
+        model_format: str = "farm",
+        pooling_strategy: str = "reduce_mean",
         emb_extraction_layer: int = -1,
     ):
         """