Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tutorials don't reflect latest changes in DB layer #11

Closed
tholor opened this issue Jan 23, 2020 · 1 comment
Closed

Tutorials don't reflect latest changes in DB layer #11

tholor opened this issue Jan 23, 2020 · 1 comment
Labels
type:bug Something isn't working

Comments

@tholor
Copy link
Member

tholor commented Jan 23, 2020

The tutorial / example has not been updated yet after the latest changes introduced by #10.

@tanaysoni: I know there will be more changes regarding elasticsearch integration, but can you please update them in a minimalistic way to keep them working :)
@tholor tholor added the type:bug Something isn't working label Jan 23, 2020
@tholor
Copy link
Member Author

tholor commented Jan 23, 2020

Fixed by #12

@tholor tholor closed this as completed Jan 23, 2020
masci pushed a commit that referenced this issue Nov 27, 2023
@ZanSara
Merge pull request #11 from deepset-ai/no-params
850b551 
feat: remove `parameters`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tholor