Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add metadata to summarizer response #2052

Closed
manupomax opened this issue Jan 23, 2022 · 5 comments
Closed

add metadata to summarizer response #2052

manupomax opened this issue Jan 23, 2022 · 5 comments
Labels
Contributions wanted! Looking for external contributions topic:metadata type:feature New feature or request

Comments

@manupomax
Copy link

currently the "summarizer" node provides context only inside the json of the response

would be nice to have metadata of original document too in the json response, similarly to the response provided by other nodes like "retriever" and "reader"

@ZanSara ZanSara added Contributions wanted! Looking for external contributions journey:first steps topic:metadata type:feature New feature or request labels Jan 24, 2022
@ZanSara
Copy link
Contributor

ZanSara commented Jan 24, 2022

Hello @manupomax, thanks for the issue! At a first glance it sounds easy to add to Haystack: would you mind taking the time to implement it? If you decide to contribute, please tag me in your PR and I'll handle the review process. Otherwise just stay tuned, soon enough somebody else will pick this one up 🙂

@SjSnowball
Copy link
Contributor

@ZanSara I would like to work on this. Currently "context" field is passed to the result from the summarizer node. Along with that, we need to pass the fields retrieved from the retriever node. Did I understand correctly?

@ZanSara
Copy link
Contributor

ZanSara commented Feb 1, 2022

Hi @SjSnowball, thanks for taking this! I understood the proposal slightly different: I think Summarizer nodes do not contain the metadata of the document they summarized into the response. Other nodes, like Retrievers and Readers, do include the original document's metadata in their results, and I think @manupomax would simply like the original document's metadata to show up in the results of the Summarizer as well.

However, it would be fantastic if @manupomax could confirm which one of there two interpretations are correct 🙂

@sjrl
Copy link
Contributor

sjrl commented Jul 26, 2022

Hey @ZanSara is it safe to close this issue, now that PR #2179 has been merged?

@ZanSara
Copy link
Contributor

ZanSara commented Jul 26, 2022

Done in #2179

@ZanSara ZanSara closed this as completed Jul 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contributions wanted! Looking for external contributions topic:metadata type:feature New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants