Passing the meta-data in the summarizer response #2179
Conversation
SjSnowball
changed the title
There was a problem hiding this comment.
Hey @SjSnowball, thank you so much for your contribution! I left a few comments because I believe there's a parameter of predict() you haven't noticed and might make your code behave unexpectedly.
I'm up for a discussion about the best approach, feel free to try different alternatives!
|
Hey @SjSnowball, do you think you will have time for this PR? Otherwise I can take care of completing and merging it myself 👍 |
|
Hi @SjSnowball this pull request looks quite good already! 👍 We plan another Haystack release for next week and it would be great if we could include this pull request in the release. Do you think you could split the test into two separate tests as suggested by @ZanSara and address the other two change requests as well? |
|
@julian-risch @ZanSara I will do the changes and push. |
|
Hey @SjSnowball, can I help you with this PR? I'm afraid it's getting stale, but I can take over, fix the last things and merge if you don't have time anymore. Let us know 🙂 |
…tack into pass_metadata_summerizer
* Passing the all the meta-data in the summerizer * Disable metadata forwarding if `generate_single_summary` is `True` * Update Documentation & Code Style * simplify tests * Update Documentation & Code Style Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
tstadel
changed the title
PR for #2052
Currently, the summarizer only returns the "context" (the original content for summerization) field and summarized content field. So have added the code snippet which will send the "context" field, summarized content field. and also the other meta-data fields.
Status (please check what you already did):
@ZanSara