Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc_id not incremented unless split_paragraphs=True #37

Closed
jgreene opened this issue Mar 6, 2020 · 2 comments
Closed

doc_id not incremented unless split_paragraphs=True #37

jgreene opened this issue Mar 6, 2020 · 2 comments
Assignees
@tanaysoni

Comments

@jgreene
Copy link

jgreene commented Mar 6, 2020

haystack/haystack/indexing/io.py

Line 53 in d33ef9c

docs_to_index.append(

all doc_ids = 1 when writing to elasticsearch
@tanaysoni tanaysoni self-assigned this Mar 6, 2020
@tanaysoni
Copy link
Contributor

Hi @jgreene, thank you for trying out Haystack and raising the issue! Would you like to create a pull request to address this? If not, I can take this up.

@tanaysoni
Copy link
Contributor

The issue is resolved as doc_id is now autogenerated by the document store instead of being passed explicitly in write_documents_to_db().

masci pushed a commit that referenced this issue Nov 27, 2023
@silvanocerza
Merge pull request #37 from deepset-ai/module-dependencies
8d8dc57 
Remove dependencies section in marshaled pipelines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tanaysoni tanaysoni

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jgreene @tanaysoni