Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert pylint version fixing #4045

Closed
silvanocerza opened this issue Feb 2, 2023 · 1 comment
Closed

Revert pylint version fixing #4045

silvanocerza opened this issue Feb 2, 2023 · 1 comment
Assignees
@silvanocerza
Labels
topic:CI topic:dependencies

Comments

@silvanocerza
Copy link
Contributor

pylint 2.16.0 has a bug that makes it crash when checking imports, there is already a fix pylint-dev/pylint#8163 but not yet released.

To prevent it from crashing in CI and making it fail continously its version has been fixed to 2.15.10 with PR #4043.

This issue is here to remind us to revert the version fixing when 2.16.1 is published.
@silvanocerza silvanocerza self-assigned this Feb 2, 2023
@silvanocerza silvanocerza mentioned this issue Feb 7, 2023
Closed
6 tasks
@silvanocerza
Copy link
Contributor Author

I messed up rebasing #4101 so the fix has been actually done in that PR instead of #4088.

Either this has been fixed, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@silvanocerza silvanocerza

Labels
topic:CI topic:dependencies
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ci: Remove pylint fixed version deepset-ai/haystack
1 participant
@silvanocerza