Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Elasticsearch connection for non-admin users #1028

Merged
merged 1 commit into from
May 4, 2021
Merged

Conversation

oryx1729
Copy link
Contributor

@oryx1729 oryx1729 commented May 4, 2021

ElasticsearchDocumentStore uses ping() to test the connection. This triggers an HTTP HEAD request to the Elasticsearch root URI. In case the user does not have sufficient privileges, it raises a Forbidden 403 response.

This PR adjusts the ping() to trigger only for the default Elasticsearch user as it might be helpful in debugging for new users.

@oryx1729 oryx1729 requested review from tholor and Timoeller and removed request for tholor May 4, 2021 10:40
Copy link
Contributor

@Timoeller Timoeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

@oryx1729 oryx1729 merged commit 9bec885 into master May 4, 2021
@oryx1729 oryx1729 deleted the fix-es-ping branch May 4, 2021 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants