Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[document_stores]Rename all document stores delete_all_documents() method to delete_documents #1047

Merged
merged 1 commit into from
May 10, 2021
Merged

[document_stores]Rename all document stores delete_all_documents() method to delete_documents #1047

merged 1 commit into from
May 10, 2021

Conversation

akkefa
Copy link
Contributor

@akkefa akkefa commented May 10, 2021

…thod to delete_documents closed #1045

Proposed changes:

  • ...

Status (please check what you already did):

  • First draft (up for discussions & feedback)
  • Final code
  • Added tests
  • Updated documentation

@akkefa akkefa changed the title [document_stores]Rename all document stores delete_all_documents() me… [document_stores]Rename all document stores delete_all_documents() method to delete_documents May 10, 2021
Copy link
Member

@tholor tholor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks for the fast PR @akkefa

@akkefa
Copy link
Contributor Author

akkefa commented May 10, 2021

@tholor I am very passionate about this project. I would love to contribute more in future.

@tholor tholor merged commit a06e445 into deepset-ai:master May 10, 2021
@tholor
Copy link
Member

tholor commented May 10, 2021

Glad to hear that! We really appreciate any help from the community and we will try to make more of our issues from the backlog so well-described that the community can pick them up more easily.

@akkefa akkefa deleted the rename_delete_all_documents branch May 10, 2021 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename delete_all_documents() -> delete_documents
2 participants