Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Python 3.6 support #1059

Merged
merged 4 commits into from
Jun 1, 2021
Merged

Remove Python 3.6 support #1059

merged 4 commits into from
Jun 1, 2021

Conversation

tholor
Copy link
Member

@tholor tholor commented May 14, 2021

Proposed changes:

  • Let's drop the support for python 3.6 as it causes issues with some dependencies (e.g. faiss) and we want to be able to use py37 features like dataclasses without any headache about backwards compatibility.

Status (please check what you already did):

  • First draft (up for discussions & feedback)
  • Final code

Fixes #1056

@lalitpagaria
Copy link
Contributor

Just suggestion to add support to perform tests on 3.7+ along with multiple OSs. It is very easy to implement.
Windows CI can be made experimental if you don't want to actively support it.

Sharing Obsei's job for reference
CI: https://github.com/lalitpagaria/obsei/blob/master/.github/workflows/build.yml
Support Matrix: https://github.com/lalitpagaria/obsei#support-and-release-matrix

@lalitpagaria
Copy link
Contributor

Should we add breaking change label?
I am not sure as this will not break anything for 3.7+ but only remove support for 3.6

@tholor tholor merged commit 022f858 into master Jun 1, 2021
@tholor tholor deleted the py_37 branch June 1, 2021 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pip install from requirements fails for python 3.6
2 participants