Improve the speed of FAISSDocumentStore.delete_documents() #1095
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed #647
Database Delete benchmark
Current delete query took 12 m 54 s 892 ms on 10000000 records
Updated delete query took 1 m 26 s 147 ms on 10000000 records
DELETE FROM document WHERE document.index = 'doc'
Sample data generation query:
insert into document ( id, text, index ) select s, md5(random()::text), 'doc' from generate_series(1, 10000000) s(i)
Status (please check what you already did):