Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PDF converter dependencies Docker #1107

Merged
merged 1 commit into from
May 31, 2021
Merged

Add PDF converter dependencies Docker #1107

merged 1 commit into from
May 31, 2021

Conversation

AlviseSembenico
Copy link
Contributor

@AlviseSembenico AlviseSembenico commented May 28, 2021 •
edited by Timoeller
Loading

Proposed changes:

  • Add requirements for PDF converter in Docker images

Status (please check what you already did):

  • First draft (up for discussions & feedback)
  • Final code
  • Added tests
  • Updated documentation

Timo edit: fixes #1094

@AlviseSembenico AlviseSembenico mentioned this pull request May 28, 2021
Closed
@Timoeller Timoeller requested a review from oryx1729 May 28, 2021 11:38
tholor
tholor approved these changes May 31, 2021
View reviewed changes
Copy link
Member

@tholor tholor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good to me. Thanks @AlviseSembenico !

@tholor tholor merged commit 6326cf5 into deepset-ai:master May 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tholor tholor tholor approved these changes

@oryx1729 oryx1729 Awaiting requested review from oryx1729

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PDFTOTEXT does not seem to be installed on GPU Docker
2 participants
@AlviseSembenico @tholor