Fixing grpcio-tools to version of colab's pre-installed grpcio #1113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
@julian-risch
|
|
It is possibly not working with all colab notebooks in tutorials.
|
|
@cvgoudar thanks for bringing this up. |
|
I removed the commas in this PR #1114 . All notebooks load correctly in colab now. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Limitations:
Google colab notebooks failed with this error message:
ContextualVersionConflict: (grpcio 1.34.1 (/usr/local/lib/python3.7/dist-packages), Requirement.parse('grpcio>=1.37.1'), {'grpcio-tools'})Further, some of the haystack tutorials fixed the version of urllib3, which caused the error message:
FileNotFoundError: [Errno 2] No such file or directory: '/usr/local/lib/python3.7/dist-packages/urllib3-1.24.3.dist-info/METADATA'Proposed changes:
!pip install grpcio-tools==1.34.1urllib3==1.25.4Limitations:
There are still some error messages left but they do not affect execution. Most of them will vanish with the next FARM release by allowing torch version 1.8.
closes #1067