Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinguish labels for calculating similarity scores #1124

Merged
merged 2 commits into from
Jun 2, 2021

Conversation

julian-risch
Copy link
Member

Proposed changes:
The ranker now distinguishes predictions with label "0" (dissimilar) and label "1" (similar) when extracting the probability of the prediction (similarity score).
Before this change, the re-ranking gave wrong results when documents to be re-ranked had a probability larger than 0.5 of being dissimilar. This probability was wrongly assumed to be the similarity score.

@julian-risch julian-risch requested a review from tholor June 2, 2021 09:33
Copy link
Member

@tholor tholor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have we documented this requirement somewhere that the re-ranker model was trained on samples with label=1 for similar query + doc? If not, maybe worth adding to the docstring or usage page

@julian-risch julian-risch merged commit 8e3d0d1 into master Jun 2, 2021
@julian-risch julian-risch deleted the fix-ranker-similarity-scores branch June 2, 2021 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants