Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docstring for RAG #1149

Merged
merged 4 commits into from
Aug 9, 2021
Merged

Update docstring for RAG #1149

merged 4 commits into from
Aug 9, 2021

Conversation

bishalgaire
Copy link
Contributor

Initialize retriever in RAG generator

Proposed changes:

  • ...

Status (please check what you already did):

  • First draft (up for discussions & feedback)
  • Final code
  • Added tests
  • Updated documentation

Initialize retriever in RAG generator
@tholor tholor requested a review from brandenchan June 8, 2021 11:51
Copy link
Contributor

@brandenchan brandenchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @bishalgaire, in this PR I see you've changed the .md file for tutorial 7. This changes only how the tutorial will appear on our website (here).

To make the changes to the tutorials themselves, you'll need to make changes to tutorials/Tutorial7_RAG_Generator.py and tutorials/Tutorial7_RAG_Generator.ipynb.

Could you commit the same change to those files too?

Copy link
Member

@tholor tholor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finishing this one as it was stale for quite a long time.
After a quick check, I believe we don't need to pass the retriever to the generator in the Tutorial as it's only needed if the documents that RAG gets in the predict() do not contain embeddings. In the tutorial we call update_embeddings(), so all docs should have the required embeddings.
@bishalgaire let us know if you faced any errors here with the original tutorial code.

@tholor tholor changed the title Update 7.md Update docstring for RAG Aug 9, 2021
@tholor tholor merged commit 4198dc6 into deepset-ai:master Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants