Make PreProcessor.process() work on lists of documents #1163
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brandenchan
changed the title
4 tasks
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
tholor
approved these changes
Jun 16, 2021
| """ | ||
| Perform document cleaning and splitting. Takes a single document as input and returns a list of documents. | ||
| Perform document cleaning and splitting. Can takes a single document or a list of documents as input and returns a list of documents. |
| documents=list(documents), | ||
| **kwargs | ||
| ) | ||
|
|
There was a problem hiding this comment.
Let's raise an error if it's neither list nor dict. Right now we just return an empty list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, applying the PreProcessor to multiple docs required extra lines of code to iterate over documents and then unnest results. This PR allows the
PreProcessor.process()method to handle both single dict inputs and also lists of dicts.