Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tutorial update #1166

Merged
merged 4 commits into from
Jun 11, 2021
Merged

Tutorial update #1166

merged 4 commits into from
Jun 11, 2021

Conversation

brandenchan
Copy link
Contributor

Changes include:

  • adding header and footer to all tutorials
  • Using launch_es() utility function
  • Add Milvus usage

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@brandenchan brandenchan requested a review from tholor June 9, 2021 13:51
@brandenchan brandenchan self-assigned this Jun 9, 2021
@brandenchan brandenchan added the type:documentation Improvements on the docs label Jun 9, 2021
tholor
tholor approved these changes Jun 10, 2021
View reviewed changes
Copy link
Member

@tholor tholor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one minor comment. Ready to merge once resolved.

docs/_src/tutorials/tutorials/1.md Show resolved Hide resolved
@brandenchan brandenchan merged commit 783893c into master Jun 11, 2021
@brandenchan brandenchan deleted the tutorial_update branch June 11, 2021 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tholor tholor tholor approved these changes

Assignees

@brandenchan brandenchan

Labels
type:documentation Improvements on the docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@brandenchan @tholor