Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Embeddings - Use update instead of replace #1181

Merged
merged 2 commits into from
Jun 14, 2021

Conversation

venuraja79
Copy link
Contributor

@venuraja79 venuraja79 commented Jun 11, 2021

Proposed changes:

  • Weaviate's replace method replaces the complete document with a new one where as "update" only updates the properties that are passed to the method and rest of the properties will be in tact.
  • Due to a defect in v1.3.0, Update Embeddings was implemented with replace. Now, changing the logic to use "update".

This is a minor change, all tests are passing.

Status (please check what you already did):

  • First draft (up for discussions & feedback)
  • Final code
  • Added tests
  • Updated documentation

@venuraja79
Copy link
Contributor Author

venuraja79 commented Jun 11, 2021

Linking #1159
@tholor, @lalitpagaria - please review and take it forward.

@venuraja79 venuraja79 changed the title WIP: Update Embeddings - Use update instead of replace Update Embeddings - Use update instead of replace Jun 12, 2021
Copy link
Member

@tholor tholor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@tholor tholor merged commit ae55927 into deepset-ai:master Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants