Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Env var CONCURRENT_REQUEST_PER_WORKER #1235

Merged
merged 2 commits into from
Jun 29, 2021

Conversation

guillim
Copy link
Contributor

@guillim guillim commented Jun 28, 2021

Proposed changes:
we create an env var CONCURRENT_REQUEST_PER_WORKER following your naming convention,
(I came a few commit backwards to find the original name). The goal is to allow people to choose when a "busy" signal is sent by the FAST_API when concurent requests are made

Status (please check what you already did):

  • First draft (up for discussions & feedback)
  • Final code
  • Added tests

ref : #1228

…aming convention, (I came a few commit backwards to find the original name)
rest_api/config.py Outdated Show resolved Hide resolved
Copy link
Contributor

@lalitpagaria lalitpagaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tholor
Copy link
Member

tholor commented Jun 29, 2021

Great, thanks for adding this @guillim

@tholor tholor merged commit 73a4f98 into deepset-ai:master Jun 29, 2021
@tholor tholor mentioned this pull request Jun 29, 2021
@guillim guillim deleted the concurrent-request branch June 29, 2021 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants