Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ElasticsearchDocumentStore get_label_count() bug fixed. #1252

Merged
merged 1 commit into from
Jul 3, 2021
Merged

ElasticsearchDocumentStore get_label_count() bug fixed. #1252

merged 1 commit into from
Jul 3, 2021

Conversation

akkefa
Copy link
Contributor

@akkefa akkefa commented Jul 3, 2021

Proposed changes:

  • Missing label_index var added.

Status (please check what you already did):

  • First draft (up for discussions & feedback)
  • Final code
  • Added tests
  • Updated documentation

@akkefa
Copy link
Contributor Author

akkefa commented Jul 3, 2021

@tholor @brandenchan Another bug fixed.

tholor
tholor approved these changes Jul 3, 2021
View reviewed changes
Copy link
Member

@tholor tholor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍

@tholor tholor merged commit 8e117f5 into deepset-ai:master Jul 3, 2021
@akkefa akkefa deleted the ElasticsearchDocumentStore_get_labels_count_bug branch July 3, 2021 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tholor tholor tholor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@akkefa @tholor