Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add id in write_labels() for SQLDocumentStore #1253

Merged
merged 1 commit into from Jul 5, 2021
Merged

Add id in write_labels() for SQLDocumentStore #1253

merged 1 commit into from Jul 5, 2021

Conversation

akkefa
Copy link
Contributor

@akkefa akkefa commented Jul 4, 2021

Proposed changes:

  • SQLDocumentStore write_labels() id missing from label orm record.

Status (please check what you already did):

  • First draft (up for discussions & feedback)
  • Final code
  • Added tests
  • Updated documentation

@akkefa
Copy link
Contributor Author

akkefa commented Jul 4, 2021

@tholor @brandenchan write_labels() missing Id parameter in label ORM bug fixed.

@tholor tholor requested a review from oryx1729 July 5, 2021 10:33
@oryx1729 oryx1729 changed the title SQLDocumentStore write_labels() missing id bug fixed. Add id in write_labels() for SQLDocumentStore Jul 5, 2021
@oryx1729 oryx1729 changed the title Add id in write_labels() for SQLDocumentStore Add id in write_labels() for SQLDocumentStore Jul 5, 2021
@oryx1729
Copy link
Contributor

oryx1729 commented Jul 5, 2021

Hi @akkefa, thank you for the fix!

@oryx1729 oryx1729 merged commit f5a8d3c into deepset-ai:master Jul 5, 2021
@akkefa akkefa deleted the SQLDocumentStore_write_labels_bug branch July 5, 2021 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oryx1729 oryx1729 oryx1729 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@akkefa @oryx1729