Added explicit refresh call during refresh_type is false in update em… #1259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tholor
approved these changes
Jul 8, 2021
There was a problem hiding this comment.
Looking good to me! Thanks for the fix and the testing @Threepointone4 . Really appreciate it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have created PR for the #1246 issue
Why?
The
query_by_embeddingthrows error. The root cause is for some data the embedding are not created. This issue is because when we call theupdate_embeddingafter thewrite_documentsome data loss happens. Though Elastic search takes some time to refresh the index after writing to document_store. At that point, when the update embedding calls the index it takes the un-refreshed index which doesn't have full data.What is changing?
We are calling the refresh API externally before update embedding to make sure the index is refreshed and searchable.