Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pipeline eval example script #1297

Merged
merged 1 commit into from
Jul 21, 2021
Merged

Remove pipeline eval example script #1297

merged 1 commit into from
Jul 21, 2021

Conversation

tholor
Copy link
Member

@tholor tholor commented Jul 21, 2021

Proposed changes:
Let's remove this example script from the Haystack package - we should only have such things in tutorials / examples outside of the main package.

Status (please check what you already did):

  • First draft (up for discussions & feedback)
  • Final code
  • Added tests
  • Updated documentation

@tholor tholor requested a review from brandenchan July 21, 2021 07:52
Copy link
Contributor

@brandenchan brandenchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tholor tholor merged commit 4c2a0b9 into master Jul 21, 2021
@tholor tholor deleted the rm_eval_script branch July 21, 2021 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants