Integrate filters with knn queries in OpenDistroElasticsearchDocumentStore #1301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows the use of filters coupled with knn similarity search on OpenDistroElasticsearchDocumentStore instances. Fixes #1139.
brandenchan
approved these changes
Aug 3, 2021
|
Thanks for your work on this @dfhssilva ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the use of filters coupled with knn similarity search on OpenDistroElasticsearchDocumentStore instances. Fixes #1139.
Proposed changes:
KeyError: 'script_score'received, when trying to pass a filter in calling the method on an ElasticsearchDocumentStore instance.This is my first contribution for an open source project. If something is missing please let me know.
Status (please check what you already did):