New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update test documentation in readme #1355

Merged

tholor merged 1 commit into deepset-ai:master from annagruendler:patch-1

Aug 19, 2021

Contributor

annagruendler commented Aug 19, 2021

Proposed changes:

Our documentation how to run tests locally was outdated. This is particularly annoying for external, first-time contributors (see Simplify setup of local tests & update contributor docs #1353). While we should still simplify our test cases further, this PR at least updates the documentation to the current state of things.

Status (please check what you already did):

First draft (up for discussions & feedback)
Final code
Added tests
Updated documentation


          Update test documentation in readme

f50bb10

tholor approved these changes

View reviewed changes

Member

tholor left a comment

LGTM

tholor merged commit a3c746a into deepset-ai:master

mathislucka mentioned this pull request

Simplify setup of local tests & update contributor docs #1353

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment