Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Crawler support for indexing pipeline #1360

Merged
merged 4 commits into from
Aug 24, 2021
Merged

Add Crawler support for indexing pipeline #1360

merged 4 commits into from
Aug 24, 2021

Conversation

akkefa
Copy link
Contributor

@akkefa akkefa commented Aug 20, 2021

Proposed changes:

  • Add Crawler support for index pipeline

Status (please check what you already did):

  • First draft (up for discussions & feedback)
  • Added tests

closes #1322

@akkefa akkefa changed the title Add Crawler support for index pipeline Add Crawler support for indexing pipeline Aug 20, 2021
@akkefa
Copy link
Contributor Author

akkefa commented Aug 20, 2021

@oryx1729 Please review my changes.

@akkefa akkefa marked this pull request as ready for review August 20, 2021 12:01
oryx1729
oryx1729 requested changes Aug 24, 2021
View reviewed changes
Copy link
Contributor

@oryx1729 oryx1729 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @akkefa, thank you for working on it!

@akkefa akkefa requested a review from oryx1729 August 24, 2021 11:04
@oryx1729 oryx1729 merged commit ead9673 into deepset-ai:master Aug 24, 2021
@akkefa akkefa deleted the crawler_support_for_indexing_pipeline branch August 24, 2021 15:25
@julian-risch julian-risch mentioned this pull request Sep 1, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oryx1729 oryx1729 oryx1729 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Crawler support for Indexing Pipelines
2 participants
@akkefa @oryx1729