Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for no Docker envs in Tutorial 13 #1365

Merged
merged 2 commits into from
Aug 31, 2021

Conversation

brandenchan
Copy link
Contributor

@brandenchan brandenchan commented Aug 23, 2021

As suggested here, we can make Tutorial 13 run end-to-end in colab by supplying a no docker option for Elasticsearch.

Thanks @cvgoudar for pointing this out!

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@brandenchan brandenchan self-assigned this Aug 23, 2021
Copy link
Member

@tholor tholor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brandenchan brandenchan merged commit 1938fb0 into master Aug 31, 2021
@brandenchan brandenchan deleted the no_docker_es_tutorial branch August 31, 2021 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants