Rag tutorial fixes #1375
Merged
Rag tutorial fixes #1375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`delete_all_documents` --> `delete_documents` (cf. deepset-ai#1045)
`delete_all_documents` --> `delete_documents` (cf. deepset-ai#1045)
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
julian-risch
approved these changes
Aug 30, 2021
There was a problem hiding this comment.
Looks good to me! I ran the colab notebook to test it. 👍
The failing test case is unrelated. There is an open PR that fixes that test case here: #1372
Further, I found some other places in the code where the deprecated method delete_all_documents is used. I created a new issue to replace it with delete_documents here: #1376
Thank you for your contribution!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
delete_all_documents-->delete_documents(cf. #1045)