Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust WeaviateDocumentStore import #1379

Merged
merged 1 commit into from
Aug 31, 2021
Merged

Adjust WeaviateDocumentStore import #1379

merged 1 commit into from
Aug 31, 2021

Conversation

brandenchan
Copy link
Contributor

Suggested by #1369. Add WeaviateDocumentStore to document_store/__init__.py so that it can be imported as follows:

from haystack.document_store import WeaviateDocumentStore

@brandenchan brandenchan self-assigned this Aug 30, 2021
@brandenchan brandenchan mentioned this pull request Aug 30, 2021
Closed
1 task
lalitpagaria
lalitpagaria approved these changes Aug 30, 2021
View reviewed changes
Copy link
Contributor

@lalitpagaria lalitpagaria left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@brandenchan brandenchan merged commit 4021eb8 into master Aug 31, 2021
@brandenchan brandenchan deleted the weaviate_init branch August 31, 2021 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tholor tholor tholor approved these changes

@lalitpagaria lalitpagaria lalitpagaria approved these changes

@tanaysoni tanaysoni Awaiting requested review from tanaysoni

Assignees

@brandenchan brandenchan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@brandenchan @tholor @lalitpagaria