Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Download archive from url without temp file #1470

Merged
merged 1 commit into from
Sep 23, 2021

Conversation

lalitpagaria
Copy link
Contributor

@lalitpagaria lalitpagaria commented Sep 17, 2021

Proposed changes:
Download archive from url without temp file. To prevent issue similar to #1445

I will be splitting this PR #1458 into 3 manageable parts.

  1. Download archive via stream (This will cover in this PR)
  2. Add Mac Runner based CI
  3. Add Windows Runner based CI (It is very complex, hence better to do it in separate CI action file - Refer Add CI for windows runner #1458)

Status (please check what you already did):

  • First draft (up for discussions & feedback)
  • Final code
  • Added tests (Not needed as existing test already cover part of this functionality)
  • Updated documentation (Not applicable)

@lalitpagaria
Copy link
Contributor Author

@tholor @oryx1729 @julian-risch kindly review this small PR when you have time.

Copy link
Member

@tholor tholor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for the fix @lalitpagaria !

@tholor tholor merged commit 98f7610 into master Sep 23, 2021
@tholor tholor deleted the fetch_archive_via_stream branch September 23, 2021 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants