-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regenerate API and Tutorial md files #1480
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
…aystack into regen_api_tutorials
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there already an open PR to add the new API markdown files to the website menu?
docs/_src/tutorials/tutorials/1.md
Outdated
@@ -142,7 +142,7 @@ print(dicts[:3]) | |||
document_store.write_documents(dicts) | |||
``` | |||
|
|||
## Initalize Retriever, Reader, & Pipeline | |||
## Initalize Retriever, Reader, & Finder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure about this. I would expect here Pipeline instead of Finder.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing that out, not sure how that snuck in. It's been reverted now
@@ -241,7 +241,7 @@ | |||
"cell_type": "markdown", | |||
"metadata": {}, | |||
"source": [ | |||
"## Initalize Retriever, Reader, & Pipeline\n", | |||
"## Initalize Retriever, Reader, & Finder\n", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See above
There will be a PR coming later today in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Adds API files for the question generator and classifier classes. Also adds API coverage for the Docs2Answers class