Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Define SAS model in notebook #1485

Merged
merged 2 commits into from
Sep 21, 2021
Merged

Define SAS model in notebook #1485

merged 2 commits into from
Sep 21, 2021

Conversation

brandenchan
Copy link
Contributor

Update notebook so that it uses the same SAS as in the .py equivalent

@brandenchan brandenchan self-assigned this Sep 21, 2021
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

julian-risch
julian-risch approved these changes Sep 21, 2021
View reviewed changes
Copy link
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! (Except for the bot commit, as discussed)

@brandenchan brandenchan merged commit bddee2d into master Sep 21, 2021
@brandenchan brandenchan deleted the sas_model branch September 21, 2021 15:05
@tholor tholor added the type:documentation Improvements on the docs label Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julian-risch julian-risch julian-risch approved these changes

Assignees

@brandenchan brandenchan

Labels
type:documentation Improvements on the docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@brandenchan @julian-risch @tholor