Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Crawler documentation #1588

Merged
merged 1 commit into from
Oct 14, 2021
Merged

Conversation

ju-gu
Copy link
Member

@ju-gu ju-gu commented Oct 13, 2021

Typo in documentation for crawler

can be testet by just copying the example:

from haystack.connector import Crawler

crawler = Crawler(output_dir="crawled_files")
#crawl Haystack docs, i.e. all pages that include haystack.deepset.ai/overview/
docs = crawler.crawl(urls=["https://haystack.deepset.ai/overview/get-started"],
filter_urls= ["haystack.deepset.ai/overview/"])

Typo in crawling the documentation website.
@julian-risch julian-risch self-requested a review October 14, 2021 10:03
Copy link
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@julian-risch julian-risch merged commit bd823c9 into master Oct 14, 2021
@julian-risch julian-risch deleted the update_crawler_documentation branch October 14, 2021 10:24
@tholor tholor added the type:documentation Improvements on the docs label Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:documentation Improvements on the docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants