Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix parameter names in tutorial 5 and 12 #1639

Merged
merged 6 commits into from
Oct 22, 2021
Merged

Fix parameter names in tutorial 5 and 12 #1639

merged 6 commits into from
Oct 22, 2021

Conversation

julian-risch
Copy link
Member

@julian-risch julian-risch commented Oct 22, 2021 •
edited
Loading

Proposed changes:

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@julian-risch julian-risch mentioned this pull request Oct 22, 2021
Closed
Timoeller
Timoeller approved these changes Oct 22, 2021
View reviewed changes
Copy link
Contributor

@Timoeller Timoeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for checking the other tutorials, looks good.
I already fixed Tutorial 5 in the other PR though.

@julian-risch julian-risch merged commit 6033319 into master Oct 22, 2021
@julian-risch julian-risch deleted the fix_tutorial5and12 branch October 22, 2021 15:22
@tholor tholor added the type:documentation Improvements on the docs label Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Timoeller Timoeller Timoeller approved these changes

Assignees
No one assigned
Labels
type:documentation Improvements on the docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@julian-risch @Timoeller @tholor