New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

disable file upload for InMemoryDocStore #1677

Merged

julian-risch merged 1 commit into master from disable_file_upload_inmemory

Nov 1, 2021

Member

julian-risch commented Oct 28, 2021

Proposed changes:

Disable file upload REST API for InMemoryDocStore. Indexing and query pipelines would create two different instances each with FAISS and InMemory document stores. While file upload with FAISS was already disabled, file upload with InMemoryDocStore was still enabled and this PR disables it.

A problem resulting from two separate instances of InMemoryDocStore in indexing and query pipelines where reported in #1637


          disable file upload for InMemoryDocStore

507fc55

julian-risch requested a review from tholor

October 28, 2021 16:55

tholor approved these changes

View reviewed changes

julian-risch merged commit c8df476 into master

julian-risch deleted the disable_file_upload_inmemory branch

November 1, 2021 09:39

tholor added the topic:rest_api label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment