Demo UI add env vars & other small fixes #1828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
ZanSara
commented
Nov 30, 2021
•
ZanSara
commented
- Add the possibility to set more value through env vars
- Add some more questions for the Random Questions list (tested)
- Refine some error messages and add logs
- Align docker-compose.yml and docker-compose-gpu.yml on the exposed env vars and fix a few typos
tholor
approved these changes
Nov 30, 2021
docker-compose-gpu.yml
Outdated
| @@ -52,5 +52,8 @@ services: | |||
| environment: | |||
| - API_ENDPOINT=http://haystack-api:8000 | |||
| - EVAL_FILE=eval_labels_example.csv | |||
| - HAYSTACK_UI_DISABLE_FILE_UPLOAD # docker-compose run -e HAYSTACK_UI_DISABLE_FILE_UPLOAD=1 ... | |||
| - DISABLE_FILE_UPLOAD # DISABLE_FILE_UPLOAD=1 docker-compose up | |||
There was a problem hiding this comment.
Is docker-compose in this example taking the value for the env variable from the host machine? If yes, let's clarify this in a comment for all the next variables
There was a problem hiding this comment.
Yeah looking at it now it is way more cryptic than it should 😄
…r to prevent spamming
…r to prevent spamming
… into demo_ui_add_env_vars
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.