Changed export to csv method to new answer format #1907
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julian-risch
added
the
topic:predictions
julian-risch
approved these changes
Dec 17, 2021
There was a problem hiding this comment.
LGTM! 👍
Tested it together with @Johnny-KP in a notebook:
all_preds = []
for q in query:
prediction = pipe.run(query=q, params={"Retriever": {"top_k": 10}, "Reader": {"top_k": 3}})
all_preds.append(prediction)
export_answers_to_csv(all_preds, output_file="congrats_to_your_first_pr.csv")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Export answers to csv method was broken since refactoring changes of the schema (answer format).
This PR fixes the export_answers_to_csv method
This method is not used at the moment.