-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Speed up query_by_embedding in InMemoryDocumentStore. #2091
Merged
Merged
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
a3565bd
Speed up query_by_embedding in InMemoryDocumentStore.
baregawi 26bf8fc
Make sure query and document embeddings are of the same dtype since t…
baregawi 9e0587d
Handle cases where there are 0 and 1 documents.
baregawi 386b734
Don't put entire embedding matrix on GPU at once. Use separate get_score
baregawi a4d8f0f
Norm the vectors in get_scores_numpy in a safer way.
baregawi 593c439
Merge remote-tracking branch 'origin/master' into memory_speed_up
baregawi ef7e2b7
Apply Black
github-actions[bot] 0814e57
Incorporate missing factor of 4 in memory use calculation.
baregawi a31d2aa
Apply Black
github-actions[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just double-checking: that requires about 1.5GB memory correct? In that case it's a good default value.