Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Make the docstring bot work only on master" #2114

Merged
merged 2 commits into from
Feb 2, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/update_docsstrings_tutorials.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,10 +3,10 @@ name: Update Docstrings and Tutorials
# Controls when the action will run. Triggers the workflow on push
# events but only for the master branch
on:
workflow_dispatch:
push:
branches:
branches-ignore:
- master
- benchmarks

jobs:
# This workflow contains a single job called "build"
Expand Down
2 changes: 1 addition & 1 deletion docs/_src/tutorials/tutorials/12.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ Make sure you enable the GPU runtime to experience decent speed in this tutorial

# Install the latest master of Haystack
!pip install --upgrade pip
!pip install git+https://github.com/deepset-ai/haystack.git#egg=farm-haystack[colab]
!pip install git+https://github.com/deepset-ai/haystack.git#egg=farm-haystack[colab,faiss]
```


Expand Down
21 changes: 0 additions & 21 deletions docs/_src/tutorials/tutorials/7.md
Original file line number Diff line number Diff line change
Expand Up @@ -170,27 +170,6 @@ These are used to condition the generator as it generates the answer.
What it should return then are novel text spans that form and answer to your question!


```python
# Now generate an answer for each question
for question in QUESTIONS:
# Retrieve related documents from retriever
retriever_results = retriever.retrieve(
query=question
)

# Now generate answer from question and retrieved documents
predicted_result = generator.predict(
query=question,
documents=retriever_results,
top_k=1
)

# Print you answer
answers = predicted_result["answers"]
print(f'Generated answer is \'{answers[0].answer}\' for the question = \'{question}\'')
```


```python
# Or alternatively use the Pipeline class
from haystack.pipelines import GenerativeQAPipeline
Expand Down