-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix surrounding context extraction in ParsrConverter
#2162
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the changes and our Parsr implementation now returns the context.
It does not return sentences but whole lines, so if a single line consists of many sentences a lot of text is returned.
Please open another issue for this to keep for later. I don't think we should work on this now.
But I would like to see in both Parsr and Azure some tests for the additional metadata extraction, especially since we are using external tools that might change return types without our notice. Can you please add some tests for the metadata extraction?
I added the tests and created issue #2217. Furthermore, I unified |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG
This PR fixes the extraction of surrounding contexts of tables in the
ParsrConverter
. Previously, the surrounding context was always empty ifremove_page_headers
orremove_page_footers
was set toFalse
. Also,preceding_context_len
andfollowing_context_len
was not taken into account.