Move document_name attribute to meta #217
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes all three document stores(Elasticsearch, SQL, and InMemory) compliant in how they ingest documents using the
write_documents()
method.The input dicts for
write_documents()
have a mandatorytext
field. All other metadata used for filtering documents(eg, name, author, category etc) can be passed under ameta
dict. So, a sample dict would look like this:For backward compatibility, the
meta
fields can also be passed as top-level keys in the document dict. For example,