-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polish Evaluation Tutorial #2212
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me so far but I think the filtering of no_answers needs more explanation and I would prefer to move it to a different line (earlier).
] | ||
} | ||
], | ||
"outputs": [], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here it was actually on purpose to have the output in the tutorial so that users can see the format of the Evaluation Report. I think we should keep it for that reason.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, I have included the output from just those cells which print the Evaluation Report
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! 👍 I also did a quick test run on colab and it works without any problems. With a fast internet connection in the office it took two minutes to download cross-encoder/stsb-roberta-large
but other users might need to wait much longer. We could replace it with cross-encoder/stsb-roberta-base
and mention in a comment that the large model would give even better results. Your choice. :)
Proposed changes:
To Do