Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Comment out Milvus cell on Tutorial6 #2243

Merged
merged 2 commits into from
Feb 24, 2022
Merged

Comment out Milvus cell on Tutorial6 #2243

merged 2 commits into from
Feb 24, 2022

Conversation

ZanSara
Copy link
Contributor

@ZanSara ZanSara commented Feb 24, 2022

Proposed changes:

  • Milvus cannot be started within a Colab notebook. Therefore we comment out the Milvus cell in Tutorial6, not to break the execution flow on Colab.
  • We decided not to delete it, as a reference for people running locally.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

julian-risch
julian-risch approved these changes Feb 24, 2022
View reviewed changes
Copy link
Member

@julian-risch julian-risch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@ZanSara ZanSara merged commit b475a1d into master Feb 24, 2022
@ZanSara ZanSara deleted the comment_milvus_on_tutorial_6 branch February 24, 2022 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julian-risch julian-risch julian-risch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ZanSara @julian-risch